Change in osmo-msc[master]: VTY: mark 'subscriber create imsi' command as deprecated

[fixeria]

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16954 )

Change subject: VTY: mark 'subscriber create imsi' command as deprecated
......................................................................

VTY: mark 'subscriber create imsi' command as deprecated

Neither it should appear in the interactive VTY nor in documentation.

Change-Id: I208faab69a40948af5d081edbeaf75f586dfb2e4
---
M doc/manuals/vty/msc_vty_reference.xml
M src/libmsc/msc_vty.c
2 files changed, 6 insertions(+), 23 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  neels: Looks good to me, approved



diff --git a/doc/manuals/vty/msc_vty_reference.xml b/doc/manuals/vty/msc_vty_reference.xml
index b98f76e..7fba1a9 100644
--- a/doc/manuals/vty/msc_vty_reference.xml
+++ b/doc/manuals/vty/msc_vty_reference.xml
@@ -668,14 +668,6 @@
         <param name='expired' doc='Delete all expired SMS' />
       </params>
     </command>
-    <command id='subscriber create imsi ID'>
-      <params>
-        <param name='subscriber' doc='Operations on a Subscriber' />
-        <param name='create' doc='Create new subscriber' />
-        <param name='imsi' doc='Identify the subscriber by his IMSI' />
-        <param name='ID' doc='Identifier for the subscriber' />
-      </params>
-    </command>
     <command id='subscriber (msisdn|extension|imsi|tmsi|id) ID sms sender (msisdn|extension|imsi|tmsi|id) SENDER_ID send .LINE'>
       <params>
         <param name='subscriber' doc='Operations on a Subscriber' />
@@ -1492,14 +1484,6 @@
         <param name='expired' doc='Delete all expired SMS' />
       </params>
     </command>
-    <command id='subscriber create imsi ID'>
-      <params>
-        <param name='subscriber' doc='Operations on a Subscriber' />
-        <param name='create' doc='Create new subscriber' />
-        <param name='imsi' doc='Identify the subscriber by his IMSI' />
-        <param name='ID' doc='Identifier for the subscriber' />
-      </params>
-    </command>
     <command id='subscriber (msisdn|extension|imsi|tmsi|id) ID sms sender (msisdn|extension|imsi|tmsi|id) SENDER_ID send .LINE'>
       <params>
         <param name='subscriber' doc='Operations on a Subscriber' />
diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index cd82a07..90cfc9d 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -1222,13 +1222,12 @@
 	return CMD_SUCCESS;
 }
 
-DEFUN(subscriber_create,
-      subscriber_create_cmd,
-      "subscriber create imsi ID",
-	"Operations on a Subscriber\n" \
-	"Create new subscriber\n" \
-	"Identify the subscriber by his IMSI\n" \
-	"Identifier for the subscriber\n")
+DEFUN_DEPRECATED(subscriber_create, subscriber_create_cmd,
+		 "subscriber create imsi ID",
+		 "Operations on a Subscriber\n"
+		 "Create new subscriber\n"
+		 "Identify the subscriber by his IMSI\n"
+		 "Identifier for the subscriber\n")
 {
 	vty_out(vty, "%% 'subscriber create' now needs to be done at osmo-hlr%s",
 		VTY_NEWLINE);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16954
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I208faab69a40948af5d081edbeaf75f586dfb2e4
Gerrit-Change-Number: 16954
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200125/b279d279/attachment.htm>