This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17009 ) Change subject: tests/alloc: fix implicit conversion from 'double' to 'int8_t' ...................................................................... tests/alloc: fix implicit conversion from 'double' to 'int8_t' Looks pretty much like a typo. Both '-1' and '.' symbols are neighbours in QWERTZ keyboard layout, so it must be -1. Found by Clang [-Wliteral-conversion]. Change-Id: Id4eb2dcc3b44e18096c7b94efb7260e2400c596b --- M tests/alloc/AllocTest.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/09/17009/1 diff --git a/tests/alloc/AllocTest.cpp b/tests/alloc/AllocTest.cpp index 123f879..2fdee3f 100644 --- a/tests/alloc/AllocTest.cpp +++ b/tests/alloc/AllocTest.cpp @@ -309,7 +309,7 @@ tfi = the_bts.tfi_find_free(GPRS_RLCMAC_UL_TBF, &trx_no, -1); OSMO_ASSERT(tfi >= 0); - ul_tbf = tbf_alloc_ul_tbf(bts, NULL, .1, ms_class, 0, false); + ul_tbf = tbf_alloc_ul_tbf(bts, NULL, -1, ms_class, 0, false); if (!ul_tbf) return false; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17009 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Id4eb2dcc3b44e18096c7b94efb7260e2400c596b Gerrit-Change-Number: 17009 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200124/b829d76b/attachment.htm>