Change in pysim[master]: Support for MSISDN programming

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Thu Jan 23 23:28:11 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16946 )

Change subject: Support for MSISDN programming
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/pysim/+/16946/5/pySim-prog.py 
File pySim-prog.py:

https://gerrit.osmocom.org/c/pysim/+/16946/5/pySim-prog.py@282 
PS5, Line 282: msisdn = msisdn[1:]
Why are you stripping '+' here? I believe it's needed by Card.program() to determine NPI/ToN.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16946
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie033a0ffc3697ae562eaa7a241a0f6af6c2b0594
Gerrit-Change-Number: 16946
Gerrit-PatchSet: 5
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 23 Jan 2020 23:28:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200123/d6a1a005/attachment.htm>


More information about the gerrit-log mailing list