Change in pysim[master]: Fixed reading of MSISDN parameter

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16947 )

Change subject: Fixed reading of MSISDN parameter
......................................................................


Patch Set 15:

(3 comments)

https://gerrit.osmocom.org/c/pysim/+/16947/15/pySim-read.py 
File pySim-read.py:

https://gerrit.osmocom.org/c/pysim/+/16947/15/pySim-read.py@218 
PS15, Line 218: 			xlen = len(bytes_res) - 14
> (is it always exactly 14?)
Yes, you basically habe an optional variable-sized buffer followed by several mandatory fields.


https://gerrit.osmocom.org/c/pysim/+/16947/15/pySim-read.py@219 
PS15, Line 219: 			msisdn_lhv = bytes_res[xlen:][:12]
> (a comment to explain how and why this splits the data would be nice)
A comment with the spec. reference would be the best explanation ;)


https://gerrit.osmocom.org/c/pysim/+/16947/15/pySim-read.py@222 
PS15, Line 222: 			if bcd_len != int('ff', 16):
> "int('ff', 16)": rather just write 255 or 0xff
ACK.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16947
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie914ae83d787e3f1a90f9f305bffd45053b8c863
Gerrit-Change-Number: 16947
Gerrit-PatchSet: 15
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Jan 2020 23:24:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200123/32781a94/attachment.htm>