This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16934 ) Change subject: libmsc: move subscriber expiration timer T3212 to libvlr ...................................................................... Patch Set 2: Code-Review-1 (2 comments) (-1 just for the typo, the rest is +0) Possible problem here is changing the meaning of the T3212 value. In 3GPP specs, AFAIU, this timer number is defined to be of that weird format. If we use T3212 as name, I guess we should also stick to the 3GPP definition of its value. Personally, I much prefer a unit of plain minutes from a user perspective. But not sure if we should introduce this inconsistency. a) users moving the timer to the new vty config and not understanding the different number value (would the config change?), b) techies setting T3212 according to spec and getting a different timeout; Can you take a look at 3GPP specs concerning T3212? I don't have a really strong opinion, but maybe you can prove my concern not justified or also just think through it again and then decide what you think it should be... https://gerrit.osmocom.org/c/osmo-msc/+/16934/2/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/16934/2/src/libmsc/msc_vty.c@326 PS2, Line 326: vty_out(vty, "%% Setting T2312 to %d minutes " digit swap typo T2312 https://gerrit.osmocom.org/c/osmo-msc/+/16934/2/src/libmsc/msc_vty.c@344 PS2, Line 344: "timeout.%s", VTY_NEWLINE); this message looks like the command refused to do anything. but ok. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16934 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9b12066599a7c834a53a93acf5902d91273bc74f Gerrit-Change-Number: 16934 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jan 2020 21:49:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200123/a4ac00f8/attachment.htm>