This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16932 ) Change subject: VTY: add osmo_tdef introspection and configuration commands ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@679 PS1, Line 679: return osmo_tdef_vty_set_cmd(vty, tdefs, argv + 1); > There is noting wrong with pointer arithmetic, it's just the matter of style. […] /me approves of 'argv + 1' The alternative would be &argv[1], and it's all the same anyway. https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@780 PS1, Line 780: /* TODO: can we use osmo_tdef_group for that? */ (here is the TODO I was referring to in the previous comment) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6024c104b6101666c8aa1108a043910eb75db9a5 Gerrit-Change-Number: 16932 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 23 Jan 2020 21:26:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <axilirator at gmail.com> Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200123/22b9110b/attachment.htm>