Change in osmo-sgsn[master]: WIP: implement ran change between 2g and 3g

[daniel]

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 )

Change subject: WIP: implement ran change between 2g and 3g
......................................................................


Patch Set 9:

(8 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/1/include/osmocom/sgsn/gprs_mm_state_iu_fsm.h 
File include/osmocom/sgsn/gprs_mm_state_iu_fsm.h:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/1/include/osmocom/sgsn/gprs_mm_state_iu_fsm.h@23 
PS1, Line 23: E_PMM_RAN_CHANGE
> still not adressed in current patch.
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/1/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/1/src/sgsn/gprs_gmm.c@1108 
PS1, Line 1108: if (ctx->ran_type == MM_CTX_T_GERAN_Gb)
              : 		osmo_fsm_inst_dispatch(ctx->gb.mm_state_fsm, E_MM_RAN_CHANGE, NULL);
              : 
              : 	if (ctx->ran_type == MM_CTX_T_UTRAN_Iu)
> that could be a switch/case statement, or at least an if/else, as both conditions cannot be true at  […]
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_gmm.c 
File src/sgsn/gprs_gmm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_gmm.c@1105 
PS2, Line 1105: 	if (ctx->ran_type == new_ran)
> i think it's better this way.
These are obsolete now.


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_gmm.c@1247 
PS2, Line 1247: 	if (MSG_IU_UE_CTX(msg))
> if (ctx->ran_type == MM_CTX_T_GERAN_Gb && MSG_IU_UE_CTX(msg)) […]
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_gmm.c@1660 
PS2, Line 1660: 	if (MSG_IU_UE_CTX(msg))
> Same
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_mm_state_gb_fsm.c 
File src/sgsn/gprs_mm_state_gb_fsm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_mm_state_gb_fsm.c@49 
PS2, Line 49: 	case E_MM_RAN_CHANGE:
> right. […]
I think this is handled correctly in newer patches where the RAT change detection logic is directly inside gprs_gsm_fsm and not inside the gb/iu ones.


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_mm_state_iu_fsm.c 
File src/sgsn/gprs_mm_state_iu_fsm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/2/src/sgsn/gprs_mm_state_iu_fsm.c@56 
PS2, Line 56: 	case E_PMM_RAN_CHANGE:
> Same: it can probably be received in DETACHED state.
Done


https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/9/src/sgsn/gprs_mm_state_iu_fsm.c 
File src/sgsn/gprs_mm_state_iu_fsm.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/9/src/sgsn/gprs_mm_state_iu_fsm.c@116 
PS9, Line 116: E_PMM_RAN_CHANGE
> I don't see where in the code you dispatch this event. […]
Your're right, I think this is leftover from before.
The RAT_CHANGE detection is now inside gprs_gmm_fsm.c and handles both the Gb and Iu cases. Removing E_PMM_RAN_CHANGE



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15487
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3fc614da6ba137e871ee0fe86ca22b6a4a354dd2
Gerrit-Change-Number: 15487
Gerrit-PatchSet: 9
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 22 Jan 2020 16:32:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200122/37ee789d/attachment.htm>