Change in libosmo-abis[master]: add ipa ping/pong keepalive for OML/RSL links between bts and bsc

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 )

Change subject: add ipa ping/pong keepalive for OML/RSL links between bts and bsc
......................................................................


Patch Set 10:

(2 comments)

Agree with pespin.

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c 
File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@74 
PS10, Line 74: 	struct osmo_fsm_inst** ka_fsm;
> I don't see a point in using pointers to pointers here simply to have 3 shorter lines which fit anyw […]
... or introduce a macrco ;)


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/10/src/input/ipaccess.c@130 
PS10, Line 130: 	struct osmo_fsm_inst** ka_fsm;
> Again avoid this. If you want, catch any of this in a pointer:  […]
#define FOO(e1i_ts) \
    ((e1i_ts)->driver.ipaccess.ka_fsm)

/* ... */

if (FOO(ipaccess_line_ts(bfd, line))) {
    osmo_fsm_inst_free(FOO(ipaccess_line_ts(bfd, line)));
    FOO(ipaccess_line_ts(bfd, line)) = NULL;
}

Or even better: store the result of ipaccess_line_ts(bfd, line) and make it shorter:

struct xxx *e1i_ts = ipaccess_line_ts(bfd, line);

if (FOO(e1i_ts)) {
    osmo_fsm_inst_free(FOO(e1i_ts));
    FOO(e1i_ts) = NULL;
}



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a
Gerrit-Change-Number: 14743
Gerrit-PatchSet: 10
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Assignee: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 22 Jan 2020 12:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200122/f0462657/attachment.htm>