This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16944 ) Change subject: Fixed MCC and MCC representation in the output of pySim-read ...................................................................... Patch Set 6: (2 comments) My comments are not a merge blocker, but still I would love to see them addressed. https://gerrit.osmocom.org/c/pysim/+/16944/6/pySim/utils.py File pySim/utils.py: https://gerrit.osmocom.org/c/pysim/+/16944/6/pySim/utils.py@225 PS6, Line 225: digit3 This argument can be optional and set to 0x0f by default. https://gerrit.osmocom.org/c/pysim/+/16944/6/pySim/utils.py@230 PS6, Line 230: if digit3 == 0xF: This condition is redundant, feel free to remove it. Moreover, both functions can be merged into a single derive_mncc() as they do pretty much the same things. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/16944 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie699c0a38d5ae90e4d6109e4574ce860e4044096 Gerrit-Change-Number: 16944 Gerrit-PatchSet: 6 Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com> Gerrit-Assignee: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 22 Jan 2020 12:09:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200122/88066ea4/attachment.htm>