This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 ) Change subject: WIP: implement ran change between 2g and 3g ...................................................................... Patch Set 9: (2 comments) https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/9/src/sgsn/gprs_gmm_fsm.c File src/sgsn/gprs_gmm_fsm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/9/src/sgsn/gprs_gmm_fsm.c@173 PS9, Line 173: (enum sgsn_ran_type) data; I am pretty sure Coverity is not gonna like this this hack... https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/9/src/sgsn/gprs_mm_state_iu_fsm.c File src/sgsn/gprs_mm_state_iu_fsm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/15487/9/src/sgsn/gprs_mm_state_iu_fsm.c@116 PS9, Line 116: E_PMM_RAN_CHANGE I don't see where in the code you dispatch this event. You're sending E_PMM_IMPLICIT_DETACH and E_MM_IMPLICIT_DETACH, but not E_PMM_RAN_CHANGE. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15487 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3fc614da6ba137e871ee0fe86ca22b6a4a354dd2 Gerrit-Change-Number: 15487 Gerrit-PatchSet: 9 Gerrit-Owner: lynxis lazus <lynxis at fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu> Gerrit-CC: fixeria <axilirator at gmail.com> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 21 Jan 2020 23:57:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200121/48e2ecf1/attachment.htm>