Change in libosmo-abis[master]: add ipa ping/pong keepalive for OML/RSL links between bts and bsc

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/14743 )

Change subject: add ipa ping/pong keepalive for OML/RSL links between bts and bsc
......................................................................


Patch Set 8:

(5 comments)

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/8/src/e1_input_vty.c 
File src/e1_input_vty.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/8/src/e1_input_vty.c@189 
PS8, Line 189: 		line->ipa_kap = talloc_zero(line, struct ipa_keepalive_params);
if you run "e1_line" on VTY twice -> memleak.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/8/src/e1_input_vty.c@192 
PS8, Line 192: 	} else
missing {}, but better simply call talloc_free before checking if (interval) to avoif the memleak. btw, what's this macro instead of talloc_free()?


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/8/src/input/ipaccess.c 
File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/14743/8/src/input/ipaccess.c@62 
PS8, Line 62: #define ka_fsm_for_ts(ipaline,ofd) (ipaline->ka_fsm[ofd->priv_nr-1])
1- Missing () when using the params
2- Can we rename this? it's confusing IMHO.
#define ipaccess_line_get_ts_ka_fsm(ipaline, ofd) ((ipaline)->ka_fsm[(ofd)->priv_nr - 1])


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/8/src/input/ipaccess.c@65 
PS8, Line 65: 	int line_already_initialized;
You are changing this to bool on next commit, better fix it here.


https://gerrit.osmocom.org/c/libosmo-abis/+/14743/8/src/input/ipaccess.c@66 
PS8, Line 66: 	struct osmo_fsm_inst* ka_fsm[NUM_E1_TS];
I have the feeling this should not be here but in struct e1i_ts.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/14743
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I30e3bd601e55355aaf738ee2f2c44c1ec2c46c6a
Gerrit-Change-Number: 14743
Gerrit-PatchSet: 8
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Assignee: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Jan 2020 15:17:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200121/6390d6e4/attachment.htm>