This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16941 ) Change subject: Added feature to program SPN into sysmoUSIM-SJS1 SIM cards ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/pysim/+/16941/4/pySim/cards.py File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/16941/4/pySim/cards.py@616 PS4, Line 616: content = enc_spn(p['name'], True, True) > since this is a standard file, I would actually argue that this should be done in the "Card" base cl […] Sorry for that, you're just expaning the existing program() method. We should re-factor this at some point to ensure that the Card:program() method handles all the 3GPP standard files and the model-specific sysmoUSIMSJS1:program() function just handles the prorprietary files. But that's a different future patch, not here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/16941 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia0f1a36ecb3898eaa1cf9925864e13369b1f31ce Gerrit-Change-Number: 16941 Gerrit-PatchSet: 4 Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 21 Jan 2020 12:54:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge at osmocom.org> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200121/48eabf78/attachment.htm>