Change in pysim[master]: Added support for MSISDN programming plus check for SPN length

[herlesupreeth]

herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16949 )

Change subject: Added support for MSISDN programming plus check for SPN length
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Sorry for being clueless here. 
> 
> no worries at all.  It's just that I "grew up" in Linux kernel development, and there I've learned to value the benefit of having a very clean commit history.  After all, you may want to go back and revert a single particular feature at some point, etc.  - also, having clean, single-purpose patches makes it much easier for the reviewers to understand what you're doing.
> 
>  > Should I split this commit and re-submit for review?
> 
> Yes, please.  The way how this is normally done is by 'git rebase -i' and related edits.  One of the two parts (e.g. "add support for MSISDN programming") will continue to keep the Change-Id of this commmit, while the other logical part ("check for SPN length') will become a new commit with a newly-assigned Change-Id.
> 
> Once youew new branch / list of commits on top of current master looks fine, you can simply re-push "push gerrit HEAD:refs/for/master" like you did the first time.

Thanks a lot. Your instructions were of great help.


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16949
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4399aa10a266fff0432cddfe33937b8b96ca0758
Gerrit-Change-Number: 16949
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Tue, 21 Jan 2020 12:35:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200121/ff663399/attachment.htm>