Change in pysim[master]: Added feature to read Service Provider Name (SPN) from the SIM card

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

herlesupreeth gerrit-no-reply at lists.osmocom.org
Tue Jan 21 09:16:08 UTC 2020


herlesupreeth has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16940 )

Change subject: Added feature to read Service Provider Name (SPN) from the SIM card
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review-1
> 
> (1 comment)
> 
> regarding the V-1 (verification of tests -1): If you change the output of the program, the test results will no longer match. You will need to modify the  pysim-testdata/*.ok files to the exact expected new output (can be seen in the log file of the test executor, see https://jenkins.osmocom.org/jenkins/job/gerrit-pysim/207/a1=default,a2=default,a3=default,a4=default,label=simtester/console)
> 
> Hoewever, given the test executor outputs the following:
> PLMNwAcT: Can't read file -- SW match failed! Expected 9000 and got 9404.
> OPLMNwAcT: Can't read file -- SW match failed! Expected 9000 and got 9404.
> HPLMNAcT: Can't read file -- SW match failed! Expected 9000 and got 9404.
> I think there is something broken. It seems like it needs to be investigated what 9404 means, and the SW treated accordingly.

Could you please tell me whether i can include the changes to pysim-testdata/*.ok files with expected output in the same commit or will that be a different commit? And, also the same question for fix of python2.x print to python3 print


-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16940
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8dc599a76c260ec2823ba5c9b22375b04a50daa8
Gerrit-Change-Number: 16940
Gerrit-PatchSet: 2
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Assignee: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: dexter <pmaier at sysmocom.de>
Gerrit-Comment-Date: Tue, 21 Jan 2020 09:16:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200121/333c2d28/attachment.htm>


More information about the gerrit-log mailing list