Change in osmo-bts[master]: measurment: write irssi_full_sum variable correctly

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16939 )

Change subject: measurment: write irssi_full_sum variable correctly
......................................................................

measurment: write irssi_full_sum variable correctly

The variable irssi_full_sum is not populated with a dummy value when we
are not able to compute irssi_full_sum. Instead we mistakenly write
MEASUREMENT_DUMMY_IRSSI to ber_full_sum, which is wrong

Change-Id: I44d7cb48e3c68ab1b48c78cceb9381ce3e39d7e8
Related: OS#2987
---
M src/common/measurement.c
M tests/meas/meas_test.ok
M tests/meas/meas_testcases.h
3 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/common/measurement.c b/src/common/measurement.c
index ddc1747..b883d51 100644
--- a/src/common/measurement.c
+++ b/src/common/measurement.c
@@ -656,7 +656,7 @@
 	ber_full_sum = ber_full_sum / num_ul_meas;
 
 	if (!irssi_full_sum)
-		ber_full_sum = MEASUREMENT_DUMMY_IRSSI;
+		irssi_full_sum = MEASUREMENT_DUMMY_IRSSI;
 	else
 		irssi_full_sum = irssi_full_sum / num_ul_meas_actual;
 
diff --git a/tests/meas/meas_test.ok b/tests/meas/meas_test.ok
index e62bb42..559a8e6 100644
--- a/tests/meas/meas_test.ok
+++ b/tests/meas/meas_test.ok
@@ -585,8 +585,8 @@
 meas.ext.toa256_max      |      0 |      0
 meas.ms_toa256           |      0 |      0
 meas.ext.toa256_std_dev  |      0 |      0
-meas.ul_res.full.rx_lev  |     63 |     63
-meas.ul_res.full.rx_qual |      3 |      3
+meas.ul_res.full.rx_lev  |      1 |      1
+meas.ul_res.full.rx_qual |      7 |      7
 
 
 ===========================================================
diff --git a/tests/meas/meas_testcases.h b/tests/meas/meas_testcases.h
index fefa34f..d7eee5c 100644
--- a/tests/meas/meas_testcases.h
+++ b/tests/meas/meas_testcases.h
@@ -131,8 +131,8 @@
 	.pchan = GSM_PCHAN_TCH_F,
 	.res = {
 		.success = 1,
-		.rx_lev_full = 63,
-		.rx_qual_full = 3,
+		.rx_lev_full = 1,
+		.rx_qual_full = 7,
 		.toa256_mean = 0,
 		.toa256_max = 0,
 		.toa256_min = 0,

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16939
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I44d7cb48e3c68ab1b48c78cceb9381ce3e39d7e8
Gerrit-Change-Number: 16939
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200120/f9fc4b52/attachment.htm>