Change in pysim[master]: Added feature to read Service Provider Name (SPN) from the SIM card

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/16940 )

Change subject: Added feature to read Service Provider Name (SPN) from the SIM card
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/pysim/+/16940/1/pySim-read.py 
File pySim-read.py:

https://gerrit.osmocom.org/c/pysim/+/16940/1/pySim-read.py@136 
PS1, Line 136: 		(res, sw) = scc.read_binary(EF['PLMNsel'])
             : 		if sw == '9000':
             : 			print("PLMNsel: %s" % (res))
             : 		else:
             : 			pri
unrelated whitespace change.  If you want to fix that, plase separate as separate commit marked as "cosmetic: fix up whitespace/indent" all over the file, but not mix functional and cosmetic changes in one commit.


https://gerrit.osmocom.org/c/pysim/+/16940/1/pySim-read.py@161 
PS1, Line 161: 	except Exception as e:
unrelated whitespace change.


https://gerrit.osmocom.org/c/pysim/+/16940/1/pySim-read.py@168 
PS1, Line 168: 	
unrelated whitespace change.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/16940
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I8dc599a76c260ec2823ba5c9b22375b04a50daa8
Gerrit-Change-Number: 16940
Gerrit-PatchSet: 1
Gerrit-Owner: herlesupreeth <herlesupreeth at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 20 Jan 2020 13:02:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200120/a4e93375/attachment.htm>