This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16932 ) Change subject: VTY: add osmo_tdef introspection and configuration commands ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-msc/+/16932/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/16932/1//COMMIT_MSG@15 PS1, Line 15: - MGW specific timers: > BTW, I don't like the idea of having for instance X1 in 2 different categories, I think we should av […] Well, yeah. I also don't like such overlapping, and I believe we should keep all timers in the same 'numbering space'. Can we change numbers of the existing timers? If yes, I am reserving X2.. for GERAN, X3.. for UTRAN, and X4.. for SGs ;) https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@679 PS1, Line 679: return osmo_tdef_vty_set_cmd(vty, tdefs, argv + 1); > argv[1]? There is noting wrong with pointer arithmetic, it's just the matter of style. Similar to having char *argv or char argv[] in function's arguments. I know you don't like this, but this is not prohibited by our coding standards [1]. Let's save our time for more important things, thank you! [1] https://www.osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@844 PS1, Line 844: osmo_tdef_vty_out_all(vty, list, "%*c", offset, ' '); \ > Ugh, what does "%*c" mean? Just like %c but with variable width. This nice feature is often used for alignment. https://gerrit.osmocom.org/c/osmo-msc/+/16932/1/src/libmsc/msc_vty.c@848 PS1, Line 848: "show timer [all]", > AFAIu all here is not needed at all so it can be dropped? Or otherwise leave it as mandatory, but ha […] It's here just for convenience, because help message of 'timer' does not say that it can show all timers. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6024c104b6101666c8aa1108a043910eb75db9a5 Gerrit-Change-Number: 16932 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 20 Jan 2020 11:04:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200120/9ecd4687/attachment.htm>