Change in osmo-msc[master]: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sun Jan 19 00:20:40 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16933 )

Change subject: libvlr: use generic osmo_tdef API for T3250, T3260, and T3270
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/osmo-msc/+/16933/1/src/libvlr/vlr.c 
File src/libvlr/vlr.c:

https://gerrit.osmocom.org/c/osmo-msc/+/16933/1/src/libvlr/vlr.c@a80 
PS1, Line 80: sizeof(vlr->cfg.timer)
LOL, there was a bug: sizeof(vlr->cfg.timer) is 12 != ARRAY_SIZE(vlr->cfg.timer), so a value in range 4..11 could lead to a buffer overrun ;)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16933
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ia8cf98da0aea0e626c5ff088a833d7359c43847f
Gerrit-Change-Number: 16933
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Sun, 19 Jan 2020 00:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200119/4bfef9fa/attachment.htm>


More information about the gerrit-log mailing list