Change in simtrace2[master]: increase ringbuffer size from 512 to 1024 bytes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Jan 18 19:22:40 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/16919 )

Change subject: increase ringbuffer size from 512 to 1024 bytes
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/simtrace2/+/16919/1/firmware/libcommon/include/ringbuffer.h 
File firmware/libcommon/include/ringbuffer.h:

https://gerrit.osmocom.org/c/simtrace2/+/16919/1/firmware/libcommon/include/ringbuffer.h@24 
PS1, Line 24: 1024
Makes sense to add a comment like "FIXME: not entirely sure why it needs to be *that* large".



-- 
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/16919
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: Ie713d614ec5b334e9058d5d430e4bb660f5b8b69
Gerrit-Change-Number: 16919
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <axilirator at gmail.com>
Gerrit-Comment-Date: Sat, 18 Jan 2020 19:22:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200118/25ce987f/attachment.htm>


More information about the gerrit-log mailing list