This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16902 ) Change subject: sccp: Support receiving messages with no optional params ...................................................................... sccp: Support receiving messages with no optional params Change-Id: I745bd32c62763ba2d88e74de8644c171ef506b37 --- M src/sccp2sua.c 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/sccp2sua.c b/src/sccp2sua.c index b829cf6..2be27ea 100644 --- a/src/sccp2sua.c +++ b/src/sccp2sua.c @@ -705,6 +705,12 @@ /* some bounds checking */ if (ptr_opt < msg->data || ptr_opt > msg->tail) return NULL; + + /* Q.713 section 2.3 "Coding of pointers": pointer value all zeros used + to indicate that no optional param is present. */ + if (*ptr_opt == 0) + return xua; + opt_start = ptr_opt + *ptr_opt; if (opt_start > msg->tail) return NULL; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I745bd32c62763ba2d88e74de8644c171ef506b37 Gerrit-Change-Number: 16902 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200117/60818e5e/attachment.htm>