Change in libosmo-sccp[master]: sccp: Add value_string for SCCP message types

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Jan 16 20:24:31 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/16896 )

Change subject: sccp: Add value_string for SCCP message types
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/libosmo-sccp/+/16896/1/src/sccp_types.c 
File src/sccp_types.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/16896/1/src/sccp_types.c@6 
PS1, Line 6: 	OSMO_VALUE_STRING(SCCP_MSG_TYPE_CC),
I would once again vote for having conscise names as used in the spec (CR/CC/...) rather than a lengthy SCCP_MSG_TYPE_CC in the logs.  That kind of usage is exactly why I dislike OSMO_VALUE_STRING in many situations.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/16896
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ibf3ee4be88a4ca633a01fad08d4c714bfa9008bc
Gerrit-Change-Number: 16896
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 16 Jan 2020 20:24:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200116/3862e1aa/attachment.htm>


More information about the gerrit-log mailing list