Change in libosmocore[master]: application.c: check default loglevels on startup

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Wed Jan 15 12:11:28 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/16833 )

Change subject: application.c: check default loglevels on startup
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.osmocom.org/c/libosmocore/+/16833/1/src/application.c 
File src/application.c:

https://gerrit.osmocom.org/c/libosmocore/+/16833/1/src/application.c@122 
PS1, Line 122: static void check_loglevels(const struct log_info *log_info)
> I don't really like forcing this. […]
Hmm. Maybe its a bad idea then to enforce default loglevels at all?

See ticket: http://osmocom.org/issues/2577


https://gerrit.osmocom.org/c/libosmocore/+/16833/2/src/application.c 
File src/application.c:

https://gerrit.osmocom.org/c/libosmocore/+/16833/2/src/application.c@127 
PS2, Line 127: printf
> We shall not log to stdout, because some programs may use it for writing binary data (e.g. […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/16833
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2d7e345c14a188430a0e991bfd9fb0343d05ea92
Gerrit-Change-Number: 16833
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 15 Jan 2020 12:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200115/eec1f966/attachment.htm>


More information about the gerrit-log mailing list