This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
tsaitgaist gerrit-no-reply at lists.osmocom.orgHello laforge,
I'd like you to do a code review. Please visit
https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/16858
to review the following change.
Change subject: include board (target) in filename, files are now called like
......................................................................
include board (target) in filename, files are now called like
bootloader-sysmooctsim-0.1.1-5554-dirty.elf
Change-Id: Ibdde1c02d5dd3bcd714bae1d374397d9596fede0
---
M README.md
M gcc/Makefile
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-asf4-dfu refs/changes/58/16858/1
diff --git a/README.md b/README.md
index dd61824..e63565e 100644
--- a/README.md
+++ b/README.md
@@ -46,7 +46,7 @@
The board name can be set in 'gcc/Makefile' *BOARD* variable, or provided while compiling (e.g. `make BOARD=SAME54_XPLAINED_PRO`).
*SAME54_XPLAINED_PRO* is the default value.
-The resulting firmware binary is `bootloader.bin`.
+The resulting firmware binary is `bootloader-$(BOARD)-$(GIT_VERSION).bin`.
Flashing
========
@@ -66,7 +66,7 @@
To flash the USB DFU bootloader, perform the following actions:
* remove reserved bootloader space so we can erase it: `edbg --target atmel_cm4v2 --fuse wv,29:26,15`
* erase the whole flash: `edbg --target atmel_cm4v2 --fuse v,29:26,15 --erase`
-* program the bootloader: `edbg --target atmel_cm4v2 --fuse v,29:26,15 --program --verify --file bootloader.bin`
+* program the bootloader: `edbg --target atmel_cm4v2 --fuse v,29:26,15 --program --verify --file bootloader-BOARD-XXXX.bin`
* reserve bootloader space: `edbg --target atmel_cm4v2 --fuse wv,29:26,13`
SWJ
diff --git a/gcc/Makefile b/gcc/Makefile
index 41779c3..86d199c 100644
--- a/gcc/Makefile
+++ b/gcc/Makefile
@@ -169,7 +169,8 @@
"gcc/system_same54.d" \
"atmel_start.d"
-OUTPUT_FILE_NAME := bootloader-$(GIT_VERSION)
+BOARD_LC := $(shell echo $(BOARD) | tr A-Z a-z)
+OUTPUT_FILE_NAME := bootloader-$(BOARD_LC)-$(GIT_VERSION)
QUOTE := "
OUTPUT_FILE_PATH +=$(OUTPUT_FILE_NAME).elf
OUTPUT_FILE_PATH_AS_ARGS +=$(OUTPUT_FILE_NAME).elf
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/16858
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: sysmoOCTSIM
Gerrit-Change-Id: Ibdde1c02d5dd3bcd714bae1d374397d9596fede0
Gerrit-Change-Number: 16858
Gerrit-PatchSet: 1
Gerrit-Owner: tsaitgaist <kredon at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200114/f88bb0da/attachment.htm>