Change in osmo-hlr[master]: mdns_msg.c: always call va_end

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Tue Jan 14 07:29:15 UTC 2020


osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16841 )

Change subject: mdns_msg.c: always call va_end
......................................................................

mdns_msg.c: always call va_end

Fixes: CID#207546
Change-Id: I39829e78619a6412618e1140ff9b1185bad975bd
---
M src/mslookup/mdns_msg.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/mslookup/mdns_msg.c b/src/mslookup/mdns_msg.c
index da65fef..78ea67a 100644
--- a/src/mslookup/mdns_msg.c
+++ b/src/mslookup/mdns_msg.c
@@ -213,9 +213,9 @@
 
 	va_start(ap, value_fmt);
 	value = talloc_vasprintf(ctx, value_fmt, ap);
+	va_end(ap);
 	if (!value)
 		return NULL;
-	va_end(ap);
 	r = _osmo_mdns_record_txt_encode(ctx, key, value);
 	talloc_free(value);
 	return r;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16841
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I39829e78619a6412618e1140ff9b1185bad975bd
Gerrit-Change-Number: 16841
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200114/0fe4f324/attachment.htm>


More information about the gerrit-log mailing list