Change in libosmo-abis[master]: e1d: Remove EXCEPTFD handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 12 14:37:40 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16820 )

Change subject: e1d: Remove EXCEPTFD handling
......................................................................

e1d: Remove EXCEPTFD handling

The file decscriptor 'except' handling was only added in the DAHDI
input module as the DAHDI kernel side is actually using those. I
don't think we can even use this in any way over unix domain sockets.

Change-Id: I718629179181a1de3b82e23447549f593046d91f
---
M src/input/e1d.c
1 file changed, 1 insertion(+), 3 deletions(-)

Approvals:
  tnt: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/input/e1d.c b/src/input/e1d.c
index 787bf49..bbbf8d5 100644
--- a/src/input/e1d.c
+++ b/src/input/e1d.c
@@ -144,8 +144,6 @@
 
 	switch (e1i_ts->type) {
 	case E1INP_TS_TYPE_SIGN:
-		//if (what & BSC_FD_EXCEPT)
-		//FIXME: what to do ?!?!
 		if (what & BSC_FD_READ)
 			ret = handle_ts_sign_read(bfd);
 		if (what & BSC_FD_WRITE)
@@ -221,7 +219,7 @@
 					"Could not open timeslot %d\n", ts);
 				return -EIO;
 			}
-			bfd->when = BSC_FD_READ | BSC_FD_EXCEPT;
+			bfd->when = BSC_FD_READ;
 
 			if (!e1i_ts->lapd)
 				e1i_ts->lapd = lapd_instance_alloc(1,

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/16820
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I718629179181a1de3b82e23447549f593046d91f
Gerrit-Change-Number: 16820
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200112/3f696edc/attachment.htm>


More information about the gerrit-log mailing list