Change in libosmo-abis[master]: e1d: Don't use perror() directly, use osmocom logging instead

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 12 14:37:40 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/16819 )

Change subject: e1d: Don't use perror() directly, use osmocom logging instead
......................................................................

e1d: Don't use perror() directly, use osmocom logging instead

Change-Id: I98f337f8f517b98f9b78dc173e5761687609abd8
---
M src/input/e1d.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  tnt: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/input/e1d.c b/src/input/e1d.c
index ceeb0c2..787bf49 100644
--- a/src/input/e1d.c
+++ b/src/input/e1d.c
@@ -66,13 +66,13 @@
 
 	ret = read(bfd->fd, msg->data, TS_SIGN_ALLOC_SIZE - 16);
 	if (ret < 0) {
-		perror("read ");
+		LOGP(DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno));
 		return ret;
 	}
 
 	msgb_put(msg, ret);
 	if (ret <= 1) {
-		perror("read ");
+		LOGP(DLMI, LOGL_ERROR, "%s read failed %d (%s)\n", __func__, ret, strerror(errno));
 		return ret;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/16819
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I98f337f8f517b98f9b78dc173e5761687609abd8
Gerrit-Change-Number: 16819
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Assignee: tnt <tnt at 246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: tnt <tnt at 246tNt.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200112/757113af/attachment.htm>


More information about the gerrit-log mailing list