Change in osmo-sgsn[master]: fix nullpointer: in gsm48_rx_gmm_ra_upd_req()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 12 10:47:26 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/16744 )

Change subject: fix nullpointer: in gsm48_rx_gmm_ra_upd_req()
......................................................................


Patch Set 1:

So if I understand this correctly, the mmcontext still is a GERAN mm context, but we just received the first RAU via UMTS, and then we run into this condition?  Seems like something we should have a test for. Looking at the code, we do have SGSN_Tests_Iu.TC_geran_attach_iu_rau(), which is currently commented out.

So what's missing here is:
* reference to the OS# issue that describes the bug
* reference to the test case
* reference to the Change-ID of the change that enables the test case once this is merged.

We should have that much discipline, sorry.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/16744
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ifde15dc4151d84748f0e67b32c9c260cb2d9d8fc
Gerrit-Change-Number: 16744
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Sun, 12 Jan 2020 10:47:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200112/7b3dbefe/attachment.htm>


More information about the gerrit-log mailing list