Change in osmo-msc[master]: Use GSM411_RP_* and not GSM48_CC_*

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

keith gerrit-no-reply at lists.osmocom.org
Sat Jan 11 17:38:22 UTC 2020


keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/16806 )


Change subject: Use GSM411_RP_* and not GSM48_CC_*
......................................................................

Use GSM411_RP_* and not GSM48_CC_*

d34ed5768cccab57e879bd32f38872d290c9ae89 introduced
comparison of GSM411_RP_CAUSE_MO_NUM_UNASSIGNED with
GSM48_CC_CAUSE_UNASSIGNED_NR

For consistency lets use the GSM411_RP constants
in SMS related code.

Change-Id: Ie54966560f66d2dcde905feb2eb19ef90406acd1
---
M src/libmsc/smpp_smsc.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/06/16806/1

diff --git a/src/libmsc/smpp_smsc.c b/src/libmsc/smpp_smsc.c
index 3bfb81a..df3c847 100644
--- a/src/libmsc/smpp_smsc.c
+++ b/src/libmsc/smpp_smsc.c
@@ -38,6 +38,7 @@
 #include <osmocom/core/logging.h>
 #include <osmocom/core/write_queue.h>
 #include <osmocom/core/talloc.h>
+#include <osmocom/gsm/protocol/gsm_04_11.h>
 
 #include "smpp_smsc.h"
 
@@ -327,9 +328,9 @@
 
 	*pesme = NULL;
 	if (acl)
-		return GSM48_CC_CAUSE_NETWORK_OOO;
+		return GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
 	else
-		return GSM48_CC_CAUSE_UNASSIGNED_NR;
+		return GSM411_RP_CAUSE_MO_NUM_UNASSIGNED;
 }
 
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16806
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie54966560f66d2dcde905feb2eb19ef90406acd1
Gerrit-Change-Number: 16806
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200111/e8f3bcf9/attachment.htm>


More information about the gerrit-log mailing list