Change in osmo-bts[master]: L1SAP: remove verbose logging from rach_pass_filter()

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/16800 )


Change subject: L1SAP: remove verbose logging from rach_pass_filter()
......................................................................

L1SAP: remove verbose logging from rach_pass_filter()

Due to relatively small training sequence of Access Bursts, there
can be frequent false-positives (basically noise). Fortunately,
we can distinguish them from the real Access Bursts by checking
the signal measurements attached to them (BER, ToA and C/I).

Let's avoid polluting the logs and do not print anything
if the signal measurements exceed any of the thresholds.

Change-Id: I7ab6727ffff00140a7f9e762b299b711481393f1
---
M src/common/l1sap.c
1 file changed, 7 insertions(+), 20 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/00/16800/1

diff --git a/src/common/l1sap.c b/src/common/l1sap.c
index b73de29..1be1a1a 100644
--- a/src/common/l1sap.c
+++ b/src/common/l1sap.c
@@ -1351,38 +1351,25 @@
 
 #define RACH_MIN_TOA256 -2 * 256
 
-static bool rach_pass_filter(struct ph_rach_ind_param *rach_ind, struct gsm_bts *bts,
-			     const char *chan_name)
+static bool rach_pass_filter(struct ph_rach_ind_param *rach_ind, struct gsm_bts *bts)
 {
 	int16_t toa256 = rach_ind->acc_delay_256bits;
 
 	/* Check for RACH exceeding BER threshold (ghost RACH) */
-	if (rach_ind->ber10k > bts->max_ber10k_rach) {
-		LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst on %s: "
-			"BER10k(%u) > BER10k_MAX(%u)\n", chan_name,
-			rach_ind->ber10k, bts->max_ber10k_rach);
+	if (rach_ind->ber10k > bts->max_ber10k_rach)
 		return false;
-	}
 
 	/**
 	 * Make sure that ToA (Timing of Arrival) is acceptable.
 	 * We allow early arrival up to 2 symbols, and delay
 	 * according to maximal allowed Timing Advance value.
 	 */
-	if (toa256 < RACH_MIN_TOA256 || toa256 > bts->max_ta * 256) {
-		LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst on %s: "
-			"ToA(%d) exceeds the allowed range (%d..%d)\n", chan_name,
-			toa256, RACH_MIN_TOA256, bts->max_ta * 256);
+	if (toa256 < RACH_MIN_TOA256 || toa256 > bts->max_ta * 256)
 		return false;
-	}
 
 	/* Link quality defined by C/I (Carrier-to-Interference ratio) */
-	if (rach_ind->lqual_cb < bts->min_qual_rach) {
-		LOGPFN(DL1C, LOGL_INFO, rach_ind->fn, "Ignoring an Access Burst on %s: "
-			"link quality (%d) below the minimum (%d)\n", chan_name,
-			rach_ind->lqual_cb, bts->min_qual_rach);
+	if (rach_ind->lqual_cb < bts->min_qual_rach)
 		return false;
-	}
 
 	return true;
 }
@@ -1391,7 +1378,7 @@
 static int l1sap_handover_rach(struct gsm_bts_trx *trx, struct ph_rach_ind_param *rach_ind)
 {
 	/* Filter out noise / interference / ghosts */
-	if (!rach_pass_filter(rach_ind, trx->bts, "handover")) {
+	if (!rach_pass_filter(rach_ind, trx->bts)) {
 		rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_DROP);
 		return 0;
 	}
@@ -1407,7 +1394,7 @@
 static int l1sap_pdch_rach(struct gsm_bts_trx *trx, struct ph_rach_ind_param *rach_ind)
 {
 	/* Filter out noise / interference / ghosts */
-	if (!rach_pass_filter(rach_ind, trx->bts, "PDCH"))
+	if (!rach_pass_filter(rach_ind, trx->bts))
 		return -EAGAIN;
 
 	/* PTCCH/U (Packet Timing Advance Control Channel) */
@@ -1459,7 +1446,7 @@
 		bts->load.rach.busy++;
 
 	/* Filter out noise / interference / ghosts */
-	if (!rach_pass_filter(rach_ind, bts, "CCCH")) {
+	if (!rach_pass_filter(rach_ind, bts)) {
 		rate_ctr_inc2(trx->bts->ctrs, BTS_CTR_RACH_DROP);
 		return 0;
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/16800
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7ab6727ffff00140a7f9e762b299b711481393f1
Gerrit-Change-Number: 16800
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200110/30d442e5/attachment.htm>