Change in osmo-hlr[master]: drop error log for when a subscriber does not exist

[neels]

Hello osmith, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-hlr/+/16212

to look at the new patch set (#28).

Change subject: drop error log for when a subscriber does not exist
......................................................................

drop error log for when a subscriber does not exist

Checking for existence of a subscriber and seeing that there is none is not
inherently an error. However, osmo-hlr currently logs on all occasions:

  DAUC ERROR Cannot read subscriber from db: MSISDN='1001': No such subscriber

This spams the ERROR log level. Particularly when a D-GSM setup does subscriber
existence checks for every incoming mslookup request, that potentially creates
constant ERROR logging.

The "No such subscriber" part comes from db_sel(), which might also return an
sqlite3_errmsg(). We still want those sqlite3_errmsg()es in the ERROR log.

Hence print an ERROR log only if db_sel() returns an rc != -ENOENT.

Change-Id: I5044e9b4519b948edc4e451cef0f7830d315619b
---
M src/db_hlr.c
M tests/db/db_test.err
2 files changed, 4 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/12/16212/28
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16212
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I5044e9b4519b948edc4e451cef0f7830d315619b
Gerrit-Change-Number: 16212
Gerrit-PatchSet: 28
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200107/948406e4/attachment.htm>