Change in libosmo-netif[master]: struct amr_header: copy comments to little endian part

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Jan 7 16:53:13 UTC 2020


neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/16758 )


Change subject: struct amr_header: copy comments to little endian part
......................................................................

struct amr_header: copy comments to little endian part

I will soon apply struct_endianess.py to this code, and then the comments that
are now only in the big endian part would be lost. Copy them to preserve them.

Change-Id: Ie4279928bd77a5d425d0e7a3c4d58bac3cf0230a
---
M include/osmocom/netif/amr.h
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/58/16758/1

diff --git a/include/osmocom/netif/amr.h b/include/osmocom/netif/amr.h
index 46ec86a..729d0ae 100644
--- a/include/osmocom/netif/amr.h
+++ b/include/osmocom/netif/amr.h
@@ -55,12 +55,12 @@
 #elif OSMO_IS_LITTLE_ENDIAN
 	/* Payload Header */
 	uint8_t pad1:4,
-		cmr:4;
+		cmr:4;	/* Codec Mode Request */
 	/* Table of Contents */
 	uint8_t pad2:2,
-		q:1,
-		ft:4,
-		f:1;
+		q:1,	/* OK (not damaged) at origin? */
+		ft:4,	/* coding mode */
+		f:1;	/* followed by another speech frame? */
 #endif
 } __attribute__((packed));
 

-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/16758
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie4279928bd77a5d425d0e7a3c4d58bac3cf0230a
Gerrit-Change-Number: 16758
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200107/3158287d/attachment.htm>


More information about the gerrit-log mailing list