Change in osmo-ttcn3-hacks[master]: BTS_Tests: tolerate empty measurement result on chan est.

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649 )

Change subject: BTS_Tests: tolerate empty measurement result on chan est.
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/1/bts/BTS_Tests.ttcn 
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/1/bts/BTS_Tests.ttcn@1734 
PS1, Line 1734:  * MS related measurement (l1_info, l3_info and ms timing offset. */
> missing ).
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/1/bts/BTS_Tests.ttcn@1805 
PS1, Line 1805: 
> ws
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/2/bts/BTS_Tests.ttcn 
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/2/bts/BTS_Tests.ttcn@1788 
PS2, Line 1788: 	[] RSL.receive(f_build_meas_res_tmpl_empty()) -> value rsl {
> how are we guarding this to prevent a situation where the MS is sending many empty measurement repor […]
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/3/bts/BTS_Tests.ttcn 
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649/3/bts/BTS_Tests.ttcn@1771 
PS3, Line 1771: 	var boolean chan_est := false;
> Are we always using this altstep when the channel is not yet established? Because if the channel is  […]
I do not see the problem. This variable is used to guard against two corner cases that may happen in the very beginning of the establishment phase.

The mechanism is: Once we see one of our "Osmocom" measurement reports we know that the channel is fully up and there must not be any hardcoded or empty measurement reports. If a caller uses this on a channel that is already up, then we will receive "Osmocom" measurement reports and the corner cases are not coming into play anyway.

Is the variable name confusing? maybe it should be different?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16649
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f511991349ab15e02db9c5e45f0df3645835a4
Gerrit-Change-Number: 16649
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 03 Jan 2020 13:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200103/df1e9946/attachment.htm>