Change in osmo-ttcn3-hacks[master]: PCU: fix: actually match IMSI in Packet Paging Request

[fixeria]

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695 )

Change subject: PCU: fix: actually match IMSI in Packet Paging Request
......................................................................


Patch Set 1:

(1 comment)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695/1//COMMIT_MSG@9 
PS1, Line 9: Makes the test cases fail because typeOfIdentity != '001'B.
> Well, I am not sure whether it's my fault (field order mismatch?) or a bug in OsmoPCU :/
I have (manually) verified the contents of Mobile Identity in Packet Paging Request, and it looks just fine. I also prepared a patch for Wireshark (https://code.wireshark.org/review/35625), and that's what I am getting:

ACKET_PAGING_REQUEST (34) (downlink)
  1000 10.. = MESSAGE_TYPE (DL): PACKET_PAGING_REQUEST (34)
  .... ..00 = PAGE_MODE: Normal Paging (0)
  0... .... = Exist_PERSISTENCE_LEVEL: 0
  .0.. .... = Exist_NLN: 0
  ..1. .... = Repeated_Page_info Exist: 1
  Repeated_Page_info
    ...1 .... = Repeated_Page_info:  (Union)
    u.Page_req_RR
      .... 1... = Page_request_for_RR_conn:  (Union)
      u.Mobile_Identity
        .... .100  0... .... = Length_of_Mobile_Identity_contents: 8
        0010 .... = Identity Digit 1: 2
        .... 1... = Odd/even indication: Odd number of identity digits
        .... .001 = Mobile Identity Type: IMSI (1)
        IMSI: 262420000000042
        [Association IMSI: 262420000000042]
            Mobile Country Code (MCC): Germany (262)
            Mobile Network Code (MNC): Vodafone GmbH (42)
      .00. .... = CHANNEL_NEEDED: 0
      ...0 .... = Exist_eMLPP_PRIORITY: 0

This must be a problem of TITAN's codec: we're trying to use record MobileIdentityV on non-octet-aligned buffer. Any ideas how to resolve this?

mobile_identity := {
  len := 8,
  mobile_id := {
    typeOfIdentity := '010'B,
    oddEvenInd_identity := {
      imei := {
        oddevenIndicator := '1'B,
        digits := '894900000000090'H
      }
    }
  }
}



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0afdd53fd5d2a89e139f65a7aec412a2e12511cc
Gerrit-Change-Number: 16695
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Jan 2020 21:42:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <axilirator at gmail.com>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200102/da928500/attachment.htm>