Change in osmo-ttcn3-hacks[master]: PCU: fix: actually match IMSI in Packet Paging Request

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Jan 2 12:05:12 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695 )

Change subject: PCU: fix: actually match IMSI in Packet Paging Request
......................................................................


Patch Set 1: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695/1//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695/1//COMMIT_MSG@9 
PS1, Line 9: Makes the test cases fail because typeOfIdentity != '001'B.
What do you mean here? That there's a bug in osmo-pcu?


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695/1/pcu/PCU_Tests_RAW.ttcn 
File pcu/PCU_Tests_RAW.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695/1/pcu/PCU_Tests_RAW.ttcn@1252 
PS1, Line 1252: 	var integer mi_len := lengthof(imsi);
may be clearer defining this as imsi_len and later on:
mi_size := imsi_len / 2 + ...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16695
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I0afdd53fd5d2a89e139f65a7aec412a2e12511cc
Gerrit-Change-Number: 16695
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 02 Jan 2020 12:05:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200102/dd43426e/attachment.htm>


More information about the gerrit-log mailing list