Change in osmo-bts[master]: vty: fix left shift by 31 cannot be represented in type 'int'

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Vadim Yanitskiy gerrit-no-reply at lists.osmocom.org
Sat Feb 29 00:57:11 UTC 2020


Vadim Yanitskiy has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17290 )

Change subject: vty: fix left shift by 31 cannot be represented in type 'int'
......................................................................

vty: fix left shift by 31 cannot be represented in type 'int'

Change-Id: I3e5940e8f360bf6563f4c1b5ebd09579f9108c81
---
M src/common/vty.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved



diff --git a/src/common/vty.c b/src/common/vty.c
index 1be0ac0..c03f0d4 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -250,7 +250,7 @@
 			bts->agch_queue.high_level, VTY_NEWLINE);
 
 	for (i = 0; i < 32; i++) {
-		if (gsmtap_sapi_mask & (1 << i)) {
+		if (gsmtap_sapi_mask & ((uint32_t) 1 << i)) {
 			sapi_buf = osmo_str_tolower(get_value_string(gsmtap_sapi_names, i));
 			vty_out(vty, " gsmtap-sapi %s%s", sapi_buf, VTY_NEWLINE);
 		}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17290
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I3e5940e8f360bf6563f4c1b5ebd09579f9108c81
Gerrit-Change-Number: 17290
Gerrit-PatchSet: 2
Gerrit-Owner: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200229/7cde5619/attachment.htm>


More information about the gerrit-log mailing list