Change in osmo-ggsn[master]: netns: Improve error checking

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Feb 26 22:02:31 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17254 )

Change subject: netns: Improve error checking
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ggsn/+/17254/2/lib/netns.c 
File lib/netns.c:

https://gerrit.osmocom.org/c/osmo-ggsn/+/17254/2/lib/netns.c@91 
PS2, Line 91: 		return -errno;
you need to close(fd) in this and the below return clause.


https://gerrit.osmocom.org/c/osmo-ggsn/+/17254/2/lib/netns.c@115 
PS2, Line 115: 		return -errno;
you need to close(sk) in this and the below return clause.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ggsn/+/17254
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ggsn
Gerrit-Branch: master
Gerrit-Change-Id: I9b9c8fd6eeaaa7d190b8e2a34ca82088904c7708
Gerrit-Change-Number: 17254
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 26 Feb 2020 22:02:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200226/06741d1d/attachment.htm>


More information about the gerrit-log mailing list