This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17269 ) Change subject: osmo-sim-test: initalize tlv_parsed structure with zeros ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/17269/1/utils/osmo-sim-test.c File utils/osmo-sim-test.c: https://gerrit.osmocom.org/c/libosmocore/+/17269/1/utils/osmo-sim-test.c@322 PS1, Line 322: struct tlv_parsed tp = { 0 }; tlp_parsed should be properly initialized by tlv_parse(), no need for this. https://gerrit.osmocom.org/c/libosmocore/+/17269/1/utils/osmo-sim-test.c@381 PS1, Line 381: if (!TLVP_PRESENT(&tp, UICC_FCP_T_FILE_SIZE)) If you want to protect against use of non-parsed tp in here, then add an extra bool "fcp_tlv_parsed" or directly check again after g_class!=0xA0. The wrong thing is using tp without having been through tlv_parse() before. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6b0209b966127a4195e6f4bcb43d49387c7646ce Gerrit-Change-Number: 17269 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 26 Feb 2020 12:13:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200226/ad657c93/attachment.htm>