This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257 ) Change subject: generic improvements for the testsbed: * fix run-tests so it can return != 0 * bail out if prepare fails * add more sanity checks to prepare * generalize usb-ids, paths * add test for flashing from application mode * add test reading simcards via pysim ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1//COMMIT_MSG@7 PS1, Line 7: generic improvements for the testsbed: first line of the commit log message should be brief one-line summary followed by empty line before detailed log message. Otherwise the entire fist paragraph will be treated as the summary by every tool. https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/05_flash_dfu_from_app.out File tests/sysmo-octsim/05_flash_dfu_from_app.out: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/05_flash_dfu_from_app.out@12 PS1, Line 12: Run-time device DFU version 0100 this kind of matching of the full stdout will break every time the distribution updates dfu-util... Why do we want to match all of the stdout and are not simply happy with the return value / exit code? https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/05_flash_dfu_from_app.sh File tests/sysmo-octsim/05_flash_dfu_from_app.sh: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/05_flash_dfu_from_app.sh@3 PS1, Line 3: is it intentional that we continue this script even if one of the called scripts return error? Otherwise 'set -e' might be used... https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/run-tests File tests/sysmo-octsim/run-tests: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257/1/tests/sysmo-octsim/run-tests@17 PS1, Line 17: echo "Prepare done" once again here (and probably for all of the shell scripts): Should we use 'set -e' for automatic error checking on every step, or do we want to only selectively manually check at some specific commands like here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/17257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I246224e29e5936b4fe40cf7d7a5ff83c9940d121 Gerrit-Change-Number: 17257 Gerrit-PatchSet: 1 Gerrit-Owner: roh <jsteiger at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Wed, 26 Feb 2020 08:50:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200226/2d5cb08c/attachment.htm>