Change in osmo-ci[master]: osmocom-nightly/latest: Build open5gs

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 24 10:02:36 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/17248 )

Change subject: osmocom-nightly/latest: Build open5gs
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-ci/+/17248/1/scripts/osmocom-latest-packages.sh 
File scripts/osmocom-latest-packages.sh:

https://gerrit.osmocom.org/c/osmo-ci/+/17248/1/scripts/osmocom-latest-packages.sh@58 
PS1, Line 58:     if [ ! -d "$project" ]; then
> Curious why you didn't follow one line style like in other git commands here. […]
I didn't really look at other git clone statements but rather at the surrounding code few lines above and below, where if clauses are used.  Also, we actually have an if-elif-else here...



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/17248
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I6752288868e5ee1378c0776b1be9f06750017c41
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Feb 2020 10:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200224/7560eebf/attachment.htm>


More information about the gerrit-log mailing list