Change in libosmocore[master]: bitvec: fix misleading description of bitvec_spare_padding()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Wed Feb 19 11:33:31 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17215 )

Change subject: bitvec: fix misleading description of bitvec_spare_padding()
......................................................................


Patch Set 1:

(4 comments)

https://gerrit.osmocom.org/c/libosmocore/+/17215/1/src/bitvec.c 
File src/bitvec.c:

https://gerrit.osmocom.org/c/libosmocore/+/17215/1/src/bitvec.c@76 
PS1, Line 76: for a given position inside a bitvec
Example.


https://gerrit.osmocom.org/c/libosmocore/+/17215/1/src/bitvec.c@98 
PS1, Line 98: for a given position inside a bitvec
Example.


https://gerrit.osmocom.org/c/libosmocore/+/17215/1/src/bitvec.c@141 
PS1, Line 141: a bit vector
Example.


https://gerrit.osmocom.org/c/libosmocore/+/17215/1/src/bitvec.c@295 
PS1, Line 295: /*! pad all remaining bits up to a given bit number
> "the given bit number", not any random one, but the one passed :)
I'm not a native speaker, but it feels like "a given bit number" is correct. And the article you suggested also looks correct :) We're basically talking about _some_ bit number and we don't know the exact value, so in this context this is just _a number_ that is passed to the function.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17215
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ie60bf7d993fe80d3c0fcd04e4c3dd81da4a2ea0b
Gerrit-Change-Number: 17215
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Feb 2020 11:33:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200219/7254c314/attachment.htm>


More information about the gerrit-log mailing list