Change in libosmocore[master]: bitvec: avoid redundant zero-initialization in bitvec_alloc()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Feb 19 09:21:06 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17218 )

Change subject: bitvec: avoid redundant zero-initialization in bitvec_alloc()
......................................................................


Patch Set 1:

I'm not a big fan of such over-optimization patches.

What if somebody inrtoduces new fields into the struct at some later point?  And if those are not explicitly initialized?

I would want to discuss such patches once somebody really runs into performance problems and has profiling data that shows these are the bottlenecks.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17218
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I40c0322d5f2febd98bae6fbe0ec2132eda6fb35b
Gerrit-Change-Number: 17218
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 19 Feb 2020 09:21:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200219/125a3f94/attachment.htm>


More information about the gerrit-log mailing list