Change in osmo-pcu[master]: csn1: bitvec_get_uint() may return a negative, use %d

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 17 21:58:44 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17202 )

Change subject: csn1: bitvec_get_uint() may return a negative, use %d
......................................................................

csn1: bitvec_get_uint() may return a negative, use %d

Change-Id: I3cfd66643ec140150a4089b0e1c493d911d3d7d4
---
M src/csn1.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/src/csn1.c b/src/csn1.c
index 2f05327..7464ac3 100644
--- a/src/csn1.c
+++ b/src/csn1.c
@@ -1309,7 +1309,7 @@
           }
         }
 
-        LOGPC(DCSN1, LOGL_NOTICE, "%s = %u | ", pDescr->sz , bitvec_get_uint(vector, 1));
+        LOGPC(DCSN1, LOGL_NOTICE, "%s = %d | ", pDescr->sz , bitvec_get_uint(vector, 1));
 
         /* existNextElement() returned FALSE, 1 bit consumed */
         remaining_bits_len--;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17202
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I3cfd66643ec140150a4089b0e1c493d911d3d7d4
Gerrit-Change-Number: 17202
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200217/72ada8ab/attachment.htm>


More information about the gerrit-log mailing list