This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17146 ) Change subject: osmo-bts-sysmo: merge measurement data and payload ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-bts/+/17146/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/17146/2//COMMIT_MSG@13 PS2, Line 13: Also lets remove the check for PCU_direct. For osmo-bts-sysmo the I'm not sure I'm following you here. So iiuc you say that we can remove the check because we don't expect to be using pcu_sock in the osmo-bts-sysmo case? IF that's the point, then I don't like the idea, it should be fine to have the possibility to run osmo-bts-sysmo with a pcu_sock. In any case, I'm not sure this change really relates to this patch and probably can be moved and discussed in a different patch. https://gerrit.osmocom.org/c/osmo-bts/+/17146/2/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/17146/2/src/common/l1sap.c@179 PS2, Line 179: int add_l1sap_header(struct gsm_bts_trx *trx, struct msgb *rmsg, I'd perhaps take the chance to document the function and explain that last params may be 0 when unknown or something similar. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17146 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iffe7865727fbf9bca8eb32a96e8ea05cf718a948 Gerrit-Change-Number: 17146 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Mon, 17 Feb 2020 10:43:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200217/3a3422c9/attachment.htm>