This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/17161 ) Change subject: tests: Missing return statement ...................................................................... tests: Missing return statement Change-Id: I4fae9f84a83af280846b07eaa139ff4a05784a2e --- M src/tests/hnb-test.c M src/tests/test_common.c 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tests/hnb-test.c b/src/tests/hnb-test.c index 446a14a..27959ec 100644 --- a/src/tests/hnb-test.c +++ b/src/tests/hnb-test.c @@ -326,7 +326,7 @@ if (len < sizeof(*ar)) { printf("GSM48 Auth Req does not fit.\n"); - return; + return -1; } printf(" :) Authentication Request :)\n"); diff --git a/src/tests/test_common.c b/src/tests/test_common.c index eeb0bec..701d581 100644 --- a/src/tests/test_common.c +++ b/src/tests/test_common.c @@ -88,6 +88,7 @@ log_set_print_filename(osmo_stderr_target, 0); log_set_use_color(osmo_stderr_target, 0); + return rc; } void test_common_cleanup(void) -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/17161 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I4fae9f84a83af280846b07eaa139ff4a05784a2e Gerrit-Change-Number: 17161 Gerrit-PatchSet: 1 Gerrit-Owner: roox <mardnh at gmx.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilirator at gmail.com> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200216/a930b56a/attachment.htm>