Change in osmo-pcu[master]: gsm_rlcmac.cpp: fix another global-buffer-overflow error reported by ...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Feb 15 09:28:24 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17053 )

Change subject: gsm_rlcmac.cpp: fix another global-buffer-overflow error reported by ASAN
......................................................................

gsm_rlcmac.cpp: fix another global-buffer-overflow error reported by ASAN

Port from wireshark.git aa3bbe5aebdc180172e7956719b26199e4784fcc.

Ported-by: Pau Espin Pedrol <pespin at sysmocom.de>
Change-Id: I808ec66011cdfe8e1193298f7fb7e92d25b45be4
---
M src/gsm_rlcmac.cpp
1 file changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/gsm_rlcmac.cpp b/src/gsm_rlcmac.cpp
index 546e7fb..839bfbb 100644
--- a/src/gsm_rlcmac.cpp
+++ b/src/gsm_rlcmac.cpp
@@ -1130,7 +1130,10 @@
   M_NEXT_EXIST (Ext_Channel_Request_desc_t, Exist_LCC_PDU, 1),
   M_UINT       (Ext_Channel_Request_desc_t,  LCC_PDU,  1),
 
-  M_NEXT_EXIST (Ext_Channel_Request_desc_t, Exist_Ext_Channel_Request_desc, 1), /* Don't use M_REC_TARRAY as we don't support multiple TBFs */
+ /* Don't use M_REC_TARRAY as we don't support multiple TBFs
+  M_NEXT_EXIST (Ext_Channel_Request_desc_t, Exist_Ext_Channel_Request_desc, 1),
+  M_TYPE       (Ext_Channel_Request_desc_t, Ext_Channel_Request_desc, Ext_Channel_Request_desc_t),*/
+  M_UINT       (Ext_Channel_Request_desc_t, Exist_Ext_Channel_Request_desc, 1),
 
 CSN_DESCR_END  (Ext_Channel_Request_desc_t)
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17053
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I808ec66011cdfe8e1193298f7fb7e92d25b45be4
Gerrit-Change-Number: 17053
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200215/646430c3/attachment.htm>


More information about the gerrit-log mailing list