Change in osmo-msc[master]: libmsc/sdp: cosmetic: fix less-than-zero comparison of an unsigned value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Feb 10 09:54:25 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17107 )

Change subject: libmsc/sdp: cosmetic: fix less-than-zero comparison of an unsigned value
......................................................................

libmsc/sdp: cosmetic: fix less-than-zero comparison of an unsigned value

Change-Id: I57ed17d8457ada69a3c22233f30339d2c0f65bce
Fixes: CID#206075
---
M src/libmsc/sdp_msg.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved



diff --git a/src/libmsc/sdp_msg.c b/src/libmsc/sdp_msg.c
index 7880978..cc54249 100644
--- a/src/libmsc/sdp_msg.c
+++ b/src/libmsc/sdp_msg.c
@@ -321,7 +321,7 @@
 	if (sscanf(src, "audio %u RTP/AVP", &port) < 1)
 		return -ENOTSUP;
 
-	if (port < 0 || port > 0xffff)
+	if (port > 0xffff)
 		return -EINVAL;
 
 	sdp->rtp.port = port;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17107
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I57ed17d8457ada69a3c22233f30339d2c0f65bce
Gerrit-Change-Number: 17107
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200210/0675b6ef/attachment.htm>


More information about the gerrit-log mailing list