Change in osmo-pcu[master]: tbf: fix NULL pointer dereference in create_[ul|dl]_ass()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Feb 10 07:47:44 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17105 )

Change subject: tbf: fix NULL pointer dereference in create_[ul|dl]_ass()
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/17105/3/src/tbf.cpp 
File src/tbf.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17105/3/src/tbf.cpp@1305 
PS3, Line 1305: /* TODO: use OTC_SELECT for such allocations */
> Let's please avoid OTC_SELECT on osmo-pcu. […]
Right. I'll update this change.


https://gerrit.osmocom.org/c/osmo-pcu/+/17105/3/src/tbf.cpp@1308 
PS3, Line 1308: 		bitvec_free(ass_vec);
> Ideally bitve_free should be fixed to support NULL pointers, as most _free() APIs.
ACK. Please see https://gerrit.osmocom.org/c/libosmocore/+/17114.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7647d17b3d03f8e193ef6e793a2d3c1967744eef
Gerrit-Change-Number: 17105
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 10 Feb 2020 07:47:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200210/7c9225e8/attachment.htm>


More information about the gerrit-log mailing list