Change in libosmocore[master]: osmo_libusb: check return value of osmo_fd_register()

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/17109 )


Change subject: osmo_libusb: check return value of osmo_fd_register()
......................................................................

osmo_libusb: check return value of osmo_fd_register()

Most likely, we should not assert() here, but let's at least log
an error message in case if osmo_fd_register() fails.

Change-Id: Ia20755ec12ee9fb0eba8322551642a96e68e1570
Related: CID#206572
---
M src/usb/osmo_libusb.c
1 file changed, 4 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/09/17109/1

diff --git a/src/usb/osmo_libusb.c b/src/usb/osmo_libusb.c
index 7a13a7e..3c8a22a 100644
--- a/src/usb/osmo_libusb.c
+++ b/src/usb/osmo_libusb.c
@@ -86,6 +86,7 @@
 	struct osmo_fd *ofd = talloc_zero(OTC_GLOBAL, struct osmo_fd);
 	libusb_context *luctx = user_data;
 	unsigned int when = 0;
+	int rc;
 
 	if (events & POLLIN)
 		when |= OSMO_FD_READ;
@@ -93,7 +94,9 @@
 		when |= OSMO_FD_WRITE;
 
 	osmo_fd_setup(ofd, fd, when, osmo_usb_fd_cb, luctx, 0);
-	osmo_fd_register(ofd);
+	rc = osmo_fd_register(ofd);
+	if (rc)
+		LOGP(DLUSB, LOGL_ERROR, "osmo_fd_register() failed with rc=%d\n", rc);
 }
 
 /* called by libusb if it wants to remove a file-descriptor */

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17109
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia20755ec12ee9fb0eba8322551642a96e68e1570
Gerrit-Change-Number: 17109
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200208/f5f1bca8/attachment.htm>