Change in osmo-pcu[master]: tbf: fix NULL-pointer dereference in gprs_rlcmac_tbf::create_ul_ass()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Sat Feb 8 20:40:12 UTC 2020


fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17105 )


Change subject: tbf: fix NULL-pointer dereference in gprs_rlcmac_tbf::create_ul_ass()
......................................................................

tbf: fix NULL-pointer dereference in gprs_rlcmac_tbf::create_ul_ass()

The problem is that bitvec_free() is not NULL safe.

Change-Id: I7647d17b3d03f8e193ef6e793a2d3c1967744eef
Fixes: CID#208181
---
M src/tbf.cpp
1 file changed, 2 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/05/17105/1

diff --git a/src/tbf.cpp b/src/tbf.cpp
index 2f79a98..9b7ade9 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -1398,7 +1398,8 @@
 	return msg;
 
 free_ret:
-	bitvec_free(ass_vec);
+	if (ass_vec != NULL)
+		bitvec_free(ass_vec);
 	talloc_free(mac_control_block);
 	msgb_free(msg);
 	return NULL;

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I7647d17b3d03f8e193ef6e793a2d3c1967744eef
Gerrit-Change-Number: 17105
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200208/ac01714d/attachment.htm>


More information about the gerrit-log mailing list