Change in osmo-pcu[master]: pcu_sock: fix memleak, allocate pcu_sock_state on stack

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Feb 6 12:11:52 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17093 )

Change subject: pcu_sock: fix memleak, allocate pcu_sock_state on stack
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/17093/1/src/osmobts_sock.cpp 
File src/osmobts_sock.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/17093/1/src/osmobts_sock.cpp@104 
PS1, Line 104: 	while (!llist_empty(&pcu_sock_state.upqueue))
Actually, calling msgb_queue_free(&pcu_sock_state.upqueue) is enough. Better keep old 2 lines ways and submit this change in a different commit.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/17093
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iea8930f443caa16f522f7c5375e0004e4e2315cb
Gerrit-Change-Number: 17093
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 06 Feb 2020 12:11:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200206/683ea205/attachment.htm>


More information about the gerrit-log mailing list